On Tue, Nov 22, 2016 at 04:36:56PM +0530, Nayna wrote: > > > On 11/22/2016 04:29 PM, Jarkko Sakkinen wrote: > > On Tue, Nov 22, 2016 at 02:32:00PM +0530, Nayna wrote: > > > > > > > > > On 11/22/2016 01:25 AM, Jarkko Sakkinen wrote: > > > > On Mon, Nov 21, 2016 at 03:03:51AM -0500, Nayna Jain wrote: > > > > > There is change done to introduce atomic bitops to set and test > > > > > chip->flags. > > > > > This patch fixes tpm_bios_log_setup() and tpm_sysfs_add_device() > > > > > to use test_bit() to check for TPM_CHIP_FLAG_TPM2 flag. > > > > > > > > > > Signed-off-by: Nayna Jain <na...@linux.vnet.ibm.com> > > > > > > > > I'm bit lost of the purpose of this patch. > > > > > > I was using tabrm branch which has changes related to using bitops for > > > chip->flags, but it was failing for TPM2 check in tpm_bios_log_setup() > > > with > > > the existing way of checking. Replacing existing one with test_bit() check > > > makes it work. Same in case of tpm_sysfs_add_device(). > > > > Why didn't you just response to the thread with a review comment > > especially as the patch is not applied to the master branch? > > Oh!! Ok.. Sorry, I should have done that. > Will take care next time. > > So basically it needs to be fixed as part of that patch.
NP. Thanks for reporting the issue! /Jarkko ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
