On Tue, Jan 10, 2017 at 09:18:11AM -0500, Stefan Berger wrote: > Make sure that we have not received less bytes than what is indicated > in the header of the TPM response. > > Signed-off-by: Stefan Berger <[email protected]>
NAK for the whole patch set as it is missing the cover letter. Also you should pick my validation patch to this patch set and do the check inside the new function. /Jarkko > --- > drivers/char/tpm/tpm-interface.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm-interface.c > b/drivers/char/tpm/tpm-interface.c > index fecdd3f..9d6f894 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -446,6 +446,8 @@ ssize_t tpm_transmit_cmd(struct tpm_chip *chip, const > void *cmd, > return -EFAULT; > > header = cmd; > + if (len < be32_to_cpu(header->length)) > + return -EFAULT; > > err = be32_to_cpu(header->return_code); > if (err != 0 && desc) > -- > 2.4.3 > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
