On 1/13/2017 11:43 AM, Jarkko Sakkinen wrote:

>>>> +struct tpml_digest_values {
>>>> +  u32 count;
>>>> +  struct tpmt_ha digests[TPM2_ACTIVE_PCR_BANKS];
>>>> +} __packed;
>>>
>>> Please remove this structure.
>>
>> Sorry Jarkko, I didn't understand this comment.
>> Why do we want to remove this structure.
>
> Well it is only used to pass two parameters.

Might it be good in general to reuse TPM Part 2
structures?  For someone familiar with the TPM
spec, it could make reading the device driver code
easier.



------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Reply via email to