On 01/16/2017 08:25 AM, Jarkko Sakkinen wrote: > On Mon, Jan 16, 2017 at 03:24:09PM +0200, Jarkko Sakkinen wrote: >> On Fri, Jan 13, 2017 at 09:36:34PM -0500, Stefan Berger wrote: >>> Make sure that we have not received less bytes than what is indicated >>> in the header of the TPM response. Also, check the number of bytes in >>> the response before accessing its data. >>> >>> Signed-off-by: Stefan Berger <stef...@linux.vnet.ibm.com> >> There are some things that I want to comment after all but I can give >> now >> >> Tested-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> >> >> I also noticed that this patch is not CC'd to linux-kernel. > Please go through the whole patch and remove arithmetic > from every possible place where you only end up with a > constant.
sizeof(cap.timeout) -- what do you want to do about that? Is that legitimate or do you want a number then??? What about offsetof's? ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
