On Fri, Feb 17, 2017 at 12:01:25PM -0700, Jason Gunthorpe wrote: > > I would rather review a patch with proper commit message than just pick > > from an email thread in all cases with a proper explanation what the > > patch does and why it is the right way to fix the issue. > > Of course, but I am waiting for Davide to say the approach even works > .. > > Jason
I'm not sure what would be a good function name but maybe something that would state that this is not status quo but workaround for a bug. Since I do not have any better suggestion keep the current name if nothing comes up. Probably a dev_err message would make sense here to state in klog that something is wrong in the BIOS. Since there are multiple people complaining about the issue I will take this workaround even if the BIOS is fixed. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel