----- Original Message ----- > From: "Jason Gunthorpe" <[email protected]> > To: "Jerry Snitselaar" <[email protected]> > Cc: [email protected], [email protected], "Peter > Huewe" <[email protected]>, "Jarkko > Sakkinen" <[email protected]>, "Marcel Selhorst" > <[email protected]> > Sent: Sunday, March 26, 2017 1:36:28 PM > Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks > > On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote: > > > @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip) > > interrupt = 0; > > > > tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt); > > - release_locality(chip, priv->locality, 1); > > + release_locality(chip, priv->locality); > > Why is this done during remove? The tpm core should now keep things so > that there is not a requested locality except during command so execution > we should not get here with a requested locality.. > > Jason >
You're right, this call should be dropped. With release_locality always releasing now it shouldn't have a locality when going into remove. I'll drop this in v2. Thanks, Jerry ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
