On Wed, Apr 05, 2017 at 03:33:55PM +0200, Roberto Sassu wrote: > On 4/5/2017 2:13 PM, Jarkko Sakkinen wrote: > > On Wed, Mar 29, 2017 at 12:24:51PM +0200, Roberto Sassu wrote: > > > Return the algorithms supported by the TPM. The limit > > > (TPM_ACTIVE_BANKS_MAX) has been exported to include/linux/tpm.h. > > > > > > Signed-off-by: Roberto Sassu <[email protected]> > > > > Why is this needed? > > The reason of exporting the limit is that this simplifies the > code dealing with information returned by the TPM driver interface. > > The new function tpm_pcr_algorithms() can accept as input a static > array, instead of returning a dynamic array that must be freed > by the caller. > > Since the size of the dynamic array would have been the same of > that of the active_banks array, member of the tpm_chip structure, > and since the limit is small, the choice of using static arrays > seems reasonable. > > Roberto
Still sounds confusing. Or to be honest (and I don't mean to be mean): I still don't get this at all. You are adding bunch of functions that somehow "add flexibility". I still don't have any context how IMA is using these. Maybe in the next version of the patch set you coud write some kind of simple usage example to the cover letter that would cover how these are supposed to be used. You hardly even metion IMA anywhere. It's fine to explain same things in both IMA and TPM patches in this case where both maintainers have to understand the context rather than kind of delegate that work to the maintainers :-) /Jarko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
