Are there any more changes any of you would like to see in this patch? Thanks! Josh
On Mon, May 15, 2017 at 1:49 PM, Winkler, Tomas <tomas.wink...@intel.com> wrote: > > >> -----Original Message----- >> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] >> Sent: Monday, May 15, 2017 20:46 >> To: Josh Zimmerman <jo...@google.com> >> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>; linux- >> ker...@vger.kernel.org; Winkler, Tomas <tomas.wink...@intel.com>; Jarkko >> Sakkinen <jarkko.sakki...@linux.intel.com>; tpmdd- >> de...@lists.sourceforge.net >> Subject: Re: [PATCH v3] Add "shutdown" to "struct class". >> >> On Mon, May 15, 2017 at 10:39:08AM -0700, Josh Zimmerman wrote: >> > (Continuing thread from patch v1) >> > > > On Sat, May 13, 2017 at 12:43:11PM +0000, Winkler, Tomas wrote: >> > > > > > The TPM class has some common shutdown code that must be >> > > > > > executed for all drivers. This adds some needed functionality >> > > > > > for that >> > > > > >> > > > > The issue with this is, that on some platforms the only storage >> > > > > can be eMMC and TPM is using it,. It has to be ensured that the >> > > > > storage device won't go down before TPM2_shutdown is called. >> > > > > And there is no direct device hierarchy to ensure an orderly >> shutdown. >> > > > >> > > > Something will have to use the new device links stuff to define >> > > > that dependency, but that seems unrelated to this patch? >> > > >> > > >> > > Yep, it's not directly related to this specific patch, this is more >> > > relevant >> particularly to TPM2_shutdown. >> > >> > Jason, do you want me to do that in my patch on the tpmdd-devel list? >> > If so, mind giving me a documentation pointer or two? I'm not familiar >> > with this area. >> >> No.. Ordering power management events is something someone with >> knowledge of the specific emmc platform is going to have to tackle.. >> It isn't really a core problem, platform specific code will have to setup the >> needed device links to order power management properly.. > > eMMC is just an example, that can be other storage device (ufs, nvme) and > some type of abstraction of underlying storage > dependency would be required. I just wanted to put it on the table, not sure > it has to be solved in this round. > Tomas > > > > >> >> Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
