On Fri, Jun 16, 2017 at 08:29:51PM +0200, Manuel Lauss wrote: > This RFC patch fixes 2 issues which prevent the fTPM device from being > initialized > by the tpm_crb driver: > > 1) use devm_ioremap() instead of devm_ioremap_resource() to fix the following > error > due to it not allowing overlapping resources: > > tpm_crb MSFT0101:00: can't request region for resource [mem > 0xdd84f000-0xdd84ffff] > tpm_crb: probe of MSFT0101:00 failed with error -16
No, we can't do this, it breaks other situations that rely on request_resource. We already put a work around for a very similar problem on a different system, do you have commit? commit b4e2eb0651ac3180a942d378b040c5cc045113ee Author: Jason Gunthorpe <[email protected]> Date: Tue Feb 21 14:14:24 2017 -0700 tpm crb: Work around BIOS's that report the wrong ACPI region size > 2) The fTPM uses different buffer addresses for command and response, so the > priv->cmd_size member never gets initialized. Move this initialization > to right after succesfully mapping the cmd buffer. Yes for this though, can you prepare a seperate patch and include a proper Fixes line refering to aa77ea0e43dc5bb0c1dcc9bad76afaa7faca8cab ? Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
