1. I guess you meant not to "base" my work on an unapplied patch. The patch we are submitting is not dependant on the referenced, earlier patch. It is also not including any of its changes. The former patch was only mentioned to give context, as it is a similar approach, however it is addressing another problem (Nuvoton driver). This reference can as well be removed if misleading. 2. Linebreaks in commit message should be fixed now. 3. The URL has been removed, so as the reference to the former patch.
No, I didn't run checkpatch.pl when first submitting the patch. Testing it with checkpatch.pl, the output gave me warning about lines over 80 chars. They are now solved. I am sending an updated version of the patch. Thanks, Hamza ATTAK. -----Original Message----- From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] Sent: 10 July 2017 20:15 To: Attak, Hamza <hamza.at...@hpe.com> Cc: tpmdd-devel@lists.sourceforge.net; Jacquin, Ludovic <l...@hpe.com>; Edwards, Nigel <nigel.edwa...@hpe.com> Subject: Re: [tpmdd-devel] [PATCH] msleep() delays - replace with usleep_range() in TPM 1.2/2.0 generic drivers On Mon, Jul 10, 2017 at 01:26:51PM +0000, Attak, Hamza wrote: > msleep() delays - replace with usleep_range() in TPM 1.2/2.0 generic > drivers > > Following the recent Nuvoton patch submitted by Mimi Zohar: > https://sourceforge.net/p/tpmdd/mailman/message/35685260/ 1. Please do not your work on a patch that was never applied. This one was https://patchwork.kernel.org/patch/9617835/ 2. Please break your lines properly in the commit message 3. Please use commit ID in the mainline instead of URL. Have you run scripts/checkpatch.pl? /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
