On Sat, Jul 29, 2017 at 03:24:28PM +0800, SZ Lin wrote: > Fix styling WARNINGs and Errors of tpm_ibmvtpm.c driver by using checkpatch.pl
Changes are great but you should revise the patch series so that you expain in each commit what goes wrong instead of copy paste of the checkpatch output and why your changes fixes the problem. > > SZ Lin (5): > Fix packed and aligned attribute warnings. > Fix "ERROR: code indent should use tabs where possible" > Fix 'void function return statements are not generally useful' warning > Remove unneccessary 'out of memory' message > Use __func__ instead of function name > > drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++-------------- > drivers/char/tpm/tpm_ibmvtpm.h | 2 +- > 2 files changed, 10 insertions(+), 15 deletions(-) > > -- > 2.13.3 > /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
