On Fri, Sep 15, 2017 at 06:07:26PM +0530, Nayna Jain wrote: > > > On 09/13/2017 06:28 AM, Jarkko Sakkinen wrote: > > On Wed, Sep 06, 2017 at 08:56:37AM -0400, Nayna Jain wrote: > > > The existing wait_for_tpm_stat() checks the chip status before > > > sleeping for 5 msec in a polling loop. For some functions although > > > the status isn't ready immediately, the status returns extremely > > > quickly. Waiting for 5 msec causes an unnecessary delay. An > > > example is the send() call in the tpms_tis driver. > > > > > > This patch defines __wait_for_tpm_stat(), allowing the caller > > > to specify the polling sleep timeout value within the loop. > > > The existing wait_for_tpm_stat() becomes a wrapper for this > > > function. > > > > > > After this change, performance on a TPM 1.2 with an 8 byte > > > burstcount for 1000 extends improved from ~14sec to ~10sec. > > > > > > Signed-off-by: Nayna Jain <na...@linux.vnet.ibm.com> > > > Acked-by: Mimi Zohar <zo...@linux.vnet.ibm.com> > > Please get rid of wait_for_tpm_stat() rather than further making it more > > complex. It's hardware specific stuff. This function should not exist in > > tpm-interface.c. > > I think I didn't understand the meaning of "get rid of wait_for_tpm_stat()". > Do you mean to take care of it in driver specific file ? > Can you please elaborate it ? > > Thanks & Regards, > - Nayna
It's not a generic function. It's used only in tpm_tis and tpm-xenfront. They should have their owen private functions for this. Here the sharing of code makes zero sense. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
