On 13 March 2018 at 10:23, Thiebaud Weksteen <tw...@google.com> wrote:
> On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel <ard.biesheu...@linaro.org>
> wrote:
>> On 13 March 2018 at 07:47, Hans de Goede <hdego...@redhat.com> wrote:
>> > Could the problem perhaps be that the new code for the TPM event-log is
>> > missing some handling to deal with running on a 32 bit firmware? I know
> the
>> > rest of the kernel has special code to deal with this.
>> >
> Yes, that was my guess as well.
>> That is a very good point, and I missed that this is a 64-bit kernel
>> running on 32-bit UEFI.
>> The TPM code does use efi_call_proto() directly, and now I am thinking
>> it is perhaps the allocate_pages() call that simply only initializes
>> the low 32-bits of log_tbl.
> That make sense. Would you know what happens to the arguments of the
> function in this case? (I'm thinking &log_location ?)

log_location and log_last_entry are always 64-bit quantities, and
efi_bool_t is always u8, so that shouldn't matter.

> Would it be safer to skip the code completely on EFI_MIXED systems?

Obviously, but I would like to avoid that if possible. Let's see first
if we've pinpointed it now.

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
tpmdd-devel mailing list

Reply via email to