Hi Guys,

I'm making progress with my work but getting reasonably stuck wading
through the massive amounts of code that make up the TPTP profiler.

I came across the class
org.eclipse.hyades.trace.ui.internal.util.PerftraceUtil which has a
number of helper methods to get certain elements out of the EMF Trace
model.

Can someone explain the design of this code? It's very very strange.
There's huge amounts of duplication and some tihngs I don't
understand.

For example,

The code for getAllPackages given a model object returns an Object[]
of the TRCPackage elements. Why not jsut return the actual EList? Even
stranger, the Object[] is created using a static ArrayList called
tmpList. This isn't thread safe (and it's quite bad style).

My fellow colleagues say "there must be a reason" why the code has
been designed this way but I can't think of anything.

Any help would be much appreciated.

Cheers,
Neil
_______________________________________________
tptp-tracing-profiling-tools-dev mailing list
tptp-tracing-profiling-tools-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/tptp-tracing-profiling-tools-dev

Reply via email to