Thanks Richard. The patch looks safe to me. By cc to PMC: please approve.
Regards, ____________________________________________ Eugene Chan IBM Toronto Laboratory, Canada email: [EMAIL PROTECTED] pwa: D1-649 | tieline: 313-6102 voice: 1.905.413.6102 | fax: 1.905.413.4850 Yun Song Huang <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 08/01/2008 08:39 AM Please respond to TPTP Tracing and Profiling Tools Project developer discussions <tptp-tracing-profiling-tools-dev@eclipse.org> To TPTP Tracing and Profiling Tools Project developer discussions <tptp-tracing-profiling-tools-dev@eclipse.org> cc Subject Re: [tptp-tracing-profiling-tools-dev] Request for approval: 238271 Eugene, I have created a patch for this defect. Please take a look. Actually what has done is just renaming two .bat files. P.S., When I created the patch, the following message was thrown in Eclipse. (See attached file: patch-question.bmp) --------------------- Richard Yunsong HUANG IBM Tivoli China Development Lab [EMAIL PROTECTED] | +86(10)82453021 Eugene Chan ---2008-08-01 10:33:57---Richard, Eugene Chan <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 2008-08-01 10:19 Please respond to TPTP Tracing and Profiling Tools Project developer discussions <tptp-tracing-profiling-tools-dev@eclipse.org> To TPTP Tracing and Profiling Tools Project developer discussions <tptp-tracing-profiling-tools-dev@eclipse.org> cc Subject Re: [tptp-tracing-profiling-tools-dev] Request for approval: 238271 Richard, Would you please attach the patch in the bugzilla? Regards. ____________________________________________ Eugene Chan IBM Toronto Laboratory, Canada email: [EMAIL PROTECTED] pwa: D1-649 | tieline: 313-6102 voice: 1.905.413.6102 | fax: 1.905.413.4850 Yun Song Huang <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 07/31/2008 10:19 PM Please respond to TPTP Tracing and Profiling Tools Project developer discussions <tptp-tracing-profiling-tools-dev@eclipse.org> To tptp-tracing-profiling-tools-dev@eclipse.org cc Subject [tptp-tracing-profiling-tools-dev] Request for approval: 238271 Hi, https://bugs.eclipse.org/bugs/show_bug.cgi?id=238271 - "Rename BtM .NET install script for VS2k8" 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Microsoft Visual Studio 2008 has shipped, we should remove "beta" from the installation script name. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? Yes, user can rename the script name by itself, but it's really a bad user experience. 3. Is this a regression or API breakage? Explain. No 4. Does this require new API? No 5. Who performed the code review? David Skeen 6. Is there a test case attached to the bugzilla record? No 7. What is the risk associated with this fix? Low. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No Thanks. --------------------- Richard Yunsong HUANG IBM Tivoli China Development Lab [EMAIL PROTECTED] | +86(10)82453021 _______________________________________________ tptp-tracing-profiling-tools-dev mailing list tptp-tracing-profiling-tools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/tptp-tracing-profiling-tools-dev _______________________________________________ tptp-tracing-profiling-tools-dev mailing list tptp-tracing-profiling-tools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/tptp-tracing-profiling-tools-dev [attachment "patch-question.bmp" deleted by Eugene Chan/Toronto/IBM] _______________________________________________ tptp-tracing-profiling-tools-dev mailing list tptp-tracing-profiling-tools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/tptp-tracing-profiling-tools-dev
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
<<image/gif>>
_______________________________________________ tptp-tracing-profiling-tools-dev mailing list tptp-tracing-profiling-tools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/tptp-tracing-profiling-tools-dev
