On Oct 24, 2006, at 12:58 AM, Christian Boos wrote:
> > Sergey Lipnevich wrote: >> On 10/23/06, Christopher Lenz <[EMAIL PROTECTED]> wrote: >> ... >>> The alternative would be to keep all the wiki_to_xxx() >>> invocations in >>> the controller code. That's an option I don't find attractive. >>> Moving >>> them into templates would have the following benefits: >> >> Not necessarily. Parsing the wiki text for just macros and >> preprocessors (I think it would be a fast and rather simple task) in >> code and doing the rest of the work in template is also a >> possibility. >> That's what I meant by not going the all-or-nothing route. >> > > I also thought about this solution, but it has the disadvantage of > leaving the controller code cluttered with 'wikiparse' invocations > instead of the 'wiki_to_*' ones (the latter being moved to the > templates). Moreover that parsed wiki should be "pre-rendered" (going > through the macros, call a "prerender" method for example), which is > therefore an additional step to do in the controller. So this > additional > complexity has to be compensated by some kind of benefit, and it is > not > clear at this point if there's any; I discussed it with Christopher > and > we agreed that until we find a compelling reason to do so, there > was no > need to do things that way. > > Of course if someone comes with a convincing need for this, we could > always switch to that solution at a later point. A possible work around for macro providers that need the old behavior would be to also make a post-request filter that calls add_stylesheet. That should still be executed before the template is rendered, so it should get included in the <head>. --Noah --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev -~----------~----~----~----~------~----~------~--~---
