Christian Boos wrote: > Matt Good wrote: > > ... > > I checked the patches to add the "Created" and "Modified" fields, but a > > side effect is that "Created" and "Modified" become available in the > > "Add filter" list, since it now thinks they're "text" fields of the > > ticket. > > And that's what we should have in the end, but as you said, not without > proper support for date fields.
thus "add filter" must become aware of it's limitations. [...] > > This patch will allow the use of "changetime" and "time" fields for > > sorting without putting them in "get_ticket_fields", so it avoids > > unwanted side effects: > > Yes, I like this way better for now. the 'side-effects' are not caused by the patch, but by an inproper use of the "fields" list within existent code: http://trac.edgewall.org/browser/trunk/templates/query.html?rev=4045#L117 "fields.iteritems()" should return the _full_ field list. the filerable fields should be returned by e.g.: fields.iteritems('for_filter') fields.iteritemsForFilter() filterfields.iteritems() This constuct would correct the behaviour: <option py:for="field_name, field in <USE_NEW_CONSTRUCT>" and would additionally provide a flexible way to select relevant fields out of the full-field-list. > > ... > > + ticket['time'] = format_datetime(ticket['time']) > > + ticket['changetime'] = > > format_datetime(ticket['changetime']) [...] . --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev -~----------~----~----~----~------~----~------~--~---
