Tim Hatch wrote:
> ...
>
> I've patched get_mimetype to do this[1], but I'm slightly wary of
> putting code to call Pygments in the core, even wrapped with a
> try/catch block[2].  Opinions?
>   

We need a IMimeTypeDetector interface/extension point for this.
... and we'd need the #3332 changes before that, I think, as there I've 
refactored the mime detection code and put place holders for 
IMimeTypeDetector and ICharsetDetector extension points, without 
actually implementing those as I didn't want to overload the patch which 
was already quite big...

I think it would be worth creating a branch for that, where we could 
finish the work together.
Would you be interested?

Are the other committers OK for Tim getting a commit access?

-- Christian


--~--~---------~--~----~------------~-------~--~----~
 You received this message because you are subscribed to the Google Groups 
"Trac Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to