I believe the reasoning for r4540 was to prevent search engines from
trying to index the annotation pages and incurring the performance hit
of building these pages. However, I don't think this is going to help,
since the search engine will actually have to visit the page in order
to get the <meta name="ROBOTS"> tag, so the page is still being
rendered.
Also, I think we should try to avoid too much abuse of the "and" and
"or" logic for flow-control in the templates.
This code:
<py:with vars="flags = (file and file.annotate) and 'NOINDEX, NOFOLLOW'
or dir and 'NOINDEX'">
<meta py:if="flags" name="ROBOTS" content="$flags" />
</py:with>
I think would be cleaner as:
<meta py:if="file and file.annotate" name="ROBOTS" content="NOINDEX,
NOFOLLOW" />
<meta py:if="dir" name="ROBOTS" content="NOINDEX" />
The "and" and "or" logic is very useful, but it can be harmful to
readability when overused in a single statement.
-- Matt Good
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Trac Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
