Hello all, I'd like to discuss two recent changesets with which I don't necessarily agree.
The first is r4769 [1], which fixes issue #3421 [2]. This patch visually merges two or more consecutive changesets when the author and commit messages are the same, but I'm not sure this is a good idea. In my opinion, the timeline is important in that it serves as a good overview of what's been happening to a project, but with this patch, information on changesets can is conflated. Of course, having many commits with a similar/the same message is in most cases just a Bad Idea, and I don't like how Trac codifies that this is okay. Also, with the current code this is not a preference, so I can't easily turn this behavior off. I would suggest that the changeset be entirely reverted, so the timeline just displays the changesets as-is (my preference), or that this is turned into a preference. Either way, I feel this feature is somewhat orthogonal to Trac's KISS principles. The second is r4786 [3], which fixes issue #1925 [4]. Now, I'm actually the reporter on this bug, so obviously I care about this little thing (I have maintained my working copy with a patch that fixes this for 2 years). I think it's an unobtrusive feature that makes the reports easier to use at the expense of an optional extra preference. I recently posted my patch to the comments since a committer (cboos) finally showed some interest in the ticket (it was rejected by cmlenz initially because he figured that if I just wanted the open tickets list I could get it by disabling the reports module and use the query module and its default config). In r4786, cboos fixed the ticket by making his own version of my patch. Instead of changing the navcontributor in the reports module to check for, then link to, the default_report option value, he chose to have a default -1 value for the option, then make /report/-1 link to the list (instead of /report, as before) and make /report link to the default report. I think this is a bad idea for two reasons: (a) -1 is kind of an ugly magic value that suddenly does something different, which should not be exposed to the URL interface (and preferably not to .ini file either, I'd prefer having something None-like or just leaving the default_report option out if it's not wanted). The other reason (b) is that this changes links to the report list and the default report from before: http://trac.xavamedia.nl/nts/report becomes http://trac.xavamedia.nl/nts/report/-1 http://trac.xavamedia.nl/nts/report/1 becomes http://trac.xavamedia.nl/nts/report (Provided 1 is the default_report.) So I'd like to ask the list to consider these sentiments. If this is just whining, I'll just shut up (about these issues) and maintain my own patches. If you agree, however, may be speak up and discuss how minor improvements should be implemented. Regards, Manuzhai [1] http://trac.edgewall.org/changeset/4769 [2] http://trac.edgewall.org/ticket/3421 [3] http://trac.edgewall.org/changeset/4786 [4] http://trac.edgewall.org/ticket/1925 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to trac-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
