Hi Eli,
Workflow code needs to be corrected in order to resolve the problem
with multiple selected options. See
http://genshi.edgewall.org/ticket/109#comment:1 for details.
Patch:
-----
Index: trac/ticket/api.py
===================================================================
--- trac/ticket/api.py (revision 5153)
+++ trac/ticket/api.py (working copy)
@@ -192,7 +192,7 @@
perm = PermissionSystem(self.env)
options = perm.get_users_with_permission('TICKET_MODIFY')
control.append(tag.select(
- [tag.option(x, selected=(x == selected_owner and
"selected" or ""))
+ [tag.option(x, selected=(x == selected_owner and
"selected" or None))
for x in options],
id=id, name=id))
else:
@@ -203,7 +203,7 @@
id = action + "_resolve_resolution"
selected_option = req.args.get(id, 'fixed')
control.append(tag.select(
- [tag.option(x, selected=(x == selected_option and
"selected" or ""))
+ [tag.option(x, selected=(x == selected_option and
"selected" or None))
for x in options],
id=id, name=id))
if 'leave_status' in operations:
Index: sample-plugins/workflow/CodeReview.py
===================================================================
--- sample-plugins/workflow/CodeReview.py (revision 5153)
+++ sample-plugins/workflow/CodeReview.py (working copy)
@@ -42,7 +42,7 @@
actions = get_workflow_config(self.config)
label = actions[action]['name']
control = (label, tag.select(
- [tag.option(x, selected=(x == selected_value and
"selected" or "")) for x in options],
+ [tag.option(x, selected=(x == selected_value and
"selected" or None)) for x in options],
name=id, id=id))
return control
Index: sample-plugins/workflow/VoteOperation.py
===================================================================
--- sample-plugins/workflow/VoteOperation.py (revision 5153)
+++ sample-plugins/workflow/VoteOperation.py (working copy)
@@ -20,7 +20,7 @@
selected_value = req.args.get(id, 'for')
options = ["for", "against"]
control = ('vote', tag.select(
- [tag.option(x, selected=(x == selected_value and
"selected" or "")) for x in options],
+ [tag.option(x, selected=(x == selected_value and
"selected" or None)) for x in options],
name=id, id=id))
return control
-----
Regards,
Pavel
On 3/29/07, Eli Carter <[EMAIL PROTECTED]> wrote:
>
> On Wednesday 28 March 2007, pkou wrote:
> >
> > The problem is in Genshi really.
> >
> > Genshi versions 0.4dev-r493 through 0.4dev-r501 work properly.
> > 0.4dev-r502 produces wrong HTML.
> >
> > I filed ticket for Genshi: http://genshi.edgewall.org/ticket/109
> >
> > So, everything fine with the workflow, let me propose to integrate it
> > in trunk.
>
> Ah! Great, thank you for tracking that down.
>
> Eli
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
