ITicketActionController.get_ticket_changes gets to return a string
describing side-effects that is shown in the ticket's preview, but when
the change is actually made (trac.ticket.web_ui._do_save) nothing is
recorded in the ticket's change history. IMO it would be helpful to
record the side-effect description in ticket_change too, as well as any
field changes.

Additionally, the ITicketChangeListener is called before the
side-effects have been applied; this is not likely to cause many issues
in practice, but it seems wrong in principle.

I've attached a patch that changes both of these; I used a special
'field' named action to record the side-effects (this seemed to be how
attachment notifications and such had been done). Thoughts?

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac 
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Attachment: workflow-sideeffects.patch
Description: workflow-sideeffects.patch

Reply via email to