osimons wrote: > ... > Finally, a simple solution appeared to me that solves these issues, > and the patch is attached to ticket #3833 (patch for 0.10-stable > revision 5342): > http://trac.edgewall.org/attachment/ticket/3833/env_reload_5342.diff > > It just modifies trac.config.parse_if_needed() slightly to add an > optional 'check_only' parameter that instead of actually reparsing > just returns True/False if a new parse is needed. Then in > trac.web.main._open_environment() I just changed the test for env in > cache to also check if the env is outdated - and reload a fresh env if > so... >
The approach looks good to me. > As far as I can tell it works like a charm, and without side-effects > of any kind - it adds arbitrary reload of eny env on any running 'in- > memory-server', without interruption to any other projects. Much, much > better than a server restart as far as I can tell. If you enable a > component in WebAdmin 'Plugins' page it will actually 'enable' > immediately, 'disable' and it disappears. > > Please, please can I ask you to include this patch in Trac - also for > 0.10-stable as that is my current setup (I certainly consider it a > 'bugfix'... :-)? > Well, this I'm less sure about... this could have unwanted side-effects, particularly w.r.t. to the cached resources (db pool, repository pool). This is a new situation _ recreating potentially many times the environment "live" as opposed to creating it once and keeping it for the whole duration of the process _ and we shouldn't treat that change lightly. So I propose to make the change on trunk first, and only if that change proves to be unproblematic after a while, we'll backport it. -- Christian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
