On 19/11/2007, at 10:44 PM, Christian Boos <[EMAIL PROTECTED]> wrote:
>
> Alec Thomas wrote:
>> On 11/17/07, Christian Boos <[EMAIL PROTECTED]> wrote:
>>
>>> Extended time for review, as I won't be able to do anything more
>>> till
>>> Monday.
>>>
>>> ... at which point, if there's no big concerns raised, I'm going to
>>> commit like crazy and call that beta one ;-)
>>>
>>
>> #153 Email address obfuscation/truncating
>>
>> +1
>>
>> My only question is why you accumulate into email_cells rather
>> than just
>> formatting the cell in the main loop?
>>
>
> We need to know the resource for the formatting
> (format_emails(context(resource), cell['value'])), in order to do a
> fine-grained permission check for EMAIL_VIEW, and the row['id'] used
> for
> getting the resource is only known after the iteration.
>
>> #1440 Remove reached milestones from edit ticket list
>>
>> No real opinion, +0
>>
>> #2048 Wiki macros for generating `<div>`s and `<span>`s with classes
>>
>> I like this style much better than the original proposed "}}}.class"
>> one. Only real question is do we need the ";" separators? It would
>> seem more in-keeping with normal HTML to simply have:
>>
>> {{{
>> #!div class="foo" style="foo bar"
>>
>> ...
>> }}}
>>
>
> Well, given that #! can be followed by a mime-type, the more general
> idea here was to pass arguments to wiki-processors using a syntax
> similar to that of a Content-Type header. The use case for <div>
> came later.
> Anyway, looking at the current regexp, it seems that it doesn't
> matter,
> as either would work...
>
>> #2259 No notification email when adding an attachment to a ticket
>>
>> +1
>>
>> #2914 would be nice to have optional automatic line breaks in ticket
>> descriptions and comments
>>
>> +1, LGTM.
>>
>> #5651 [patch] Use 'inherit' 'file' config setting when creating a new
>> Environment (not loading defaults)
>>
>> +1
>>
>> #6043 Trunk jQuery crashes safari 2.0 and older
>>
>> I guess we check if there are any major changes in jQuery 1.1.4, do
>> some testing, and plonk it in.
>>
>
> Plus 1.1.4 is supposedly much faster. Ideally we should go with 1.2.1
> though.
>
>> #5954 Can't use prototype in plugins as $ conflicts with jquery
>>
>> No opinion, +0.
>>
>> #6278 remove unnecessary span tag
>>
>> No opinion, +0.
>>
>> #6211 IPermissionPolicy unable to grant WIKI_VIEW access
>>
>> I've updated the ticket with comments, but the
>> summary is that I think we should do the opposite of what the
>> requestor suggests :)
>>
>>
>
> I didn't see your comment but I'm definitely interested in your
> opinion
> on the matter.
Ugh. No idea what happened to it :(
But effectively what you said, plus a mention of how 'WIKI_VIEW' in
req.perm('wiki') is used by the nav code to check whether the wiki nav
item should show up at all.
This also had the implication that plugins doing old-style checks may
not work correctly with policy plugins such as the one he mentioned,
and that we should make a note of that somewhere.
>
>
> -- Christian
>
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
