Erik Bray wrote: > On Nov 9, 2007 4:13 AM, Christian Boos <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> As this is an interface change, I'd like to get some feedback on the >> following patch, which basically just adds a `get_user_groups` method to >> IPermissionStore and therefore to the DefaultPermissionStore, as well as >> a `groups` method to the PermissionCache, giving back a set of group >> strings for the perm user. >> >> The use case would be for IPermissionPolicy plugins that would need to >> ask directly for group membership of a given username (e.g. the >> GringottsPlugin on TracHacks). >> > > This would definitely be useful to me, and it's a pretty harmless addition. >
Unfortunately, when adding unit-tests to the feature, I realized that the current notion of group is wired into the DefaultPermissionStore, itself a "kind of" group provider. A proper way to fix this would probably involve to move the IPermissionGroupProvider extension point from the DefaultPermissionStore to the PermissionSystem and have the DefaultPermissionStore simply implement the IPermissionGroupProvider interface. But this probably will have performance issues. In short: this requires more work to get it working properly, so probably a 0.12 thing. -- Christian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
