Hi all, Following on from ctxtnav work was the need to move where the warnings rendered on the page. Before they rendered above the ctxtnav div as Trac did not control that and could not be sure it existed in all templates. With ctxtnav it does, and it needs to be moved below all navigation so that it doesn't appear wedged in above ctxtnav.
This is essentially this change: http://trac.edgewall.org/changeset/6353 One thing lead to another on #trac, and decided to also change the API to standardise on using the add_*() for adding such elements to chrome for rendering. The branch is a result of that an essentially makes these changes: 1. Moves the location in layout.html 2. Moves the warnings from req object to chrome 3. Changes the api to use add_warning(req, msg) instead of req.warning(msg) The full set of changes can be seen here: http://trac.edgewall.org/changeset?new=sandbox%2Fwarning-api%406355&old=sandbox%2Fwarning-api%406352 It should be completed and are mostly simple changes. However, two modules provided troublesome imports when done at toplevel, so the imports where moved to the location where they were needed. As these locations are deep inside unchartered territory for me, I would appreciate someone testing this that actually knows how to provoke warnings in this code...: - versioncontrol.api should be fine as the import is added in same location that already import Chrome - mimeview.api import is basically untested. If these last two warnings works, then the branch should be ready. :::simon https://www.coderesort.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
