PS. The inline expansion is very cool :) I just had a thought though...it would probably be a fair bit faster if it didn't have to render all the chrome. Or does this already happen?
On 09/01/2008, Alec Thomas <[EMAIL PROTECTED]> wrote: > Thanks Christian. It was a bug. Fixed in G788. > > On 09/01/2008, Christian Boos <[EMAIL PROTECTED]> wrote: > > > > Alec Thomas wrote: > > > I'm migrating Trac Hacks to 0.11 and for some reason the in-place > > > browser expansion isn't working: > > > > > > http://staging.trac-hacks.org/browser > > > > > > Any ideas what's going on? > > > > > > > > > > Looks like there's an empty line before the <DOCTYPE> in the result XHR > > that messes up the Javascript replace(/^<DOCTYPE...). > > That's apparently related to your latest changeset in Genshi ([G787]). > > The following change will fix it, but I wonder if that empty line > > leading line is not a buglet in itself? > > > > diff --git a/trac/htdocs/js/expand_dir.js b/trac/htdocs/js/expand_dir.js > > --- a/trac/htdocs/js/expand_dir.js > > +++ b/trac/htdocs/js/expand_dir.js > > @@ -81,7 +81,7 @@ function toggleDir(expander, qargs) { > > data: qargs, > > dataType: "html", > > success: function(data) { > > - var rows = $(data.replace(/^<!DOCTYPE[^>]+>/, "")).filter("tr"); > > + var rows = $(data.replace(/^\s*<!DOCTYPE[^>]+>/, "")).filter("tr"); > > if (rows.length) { > > // insert entry rows > > rows.children("td."+td_class).css("padding-left", depth); > > > > > > > > -- Christian > > > > > > > > > > > > > -- > Evolution: Taking care of those too stupid to take care of themselves. > -- Evolution: Taking care of those too stupid to take care of themselves. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
