[Trac-dev] Re: WikiRename branch (take 2)

[Noah Kantrowitz]

Christian Boos wrote:

osimons wrote:

On Jul 10, 8:43 pm, osimons <[EMAIL PROTECTED]> wrote:

On Jul 10, 7:51 pm, Christian Boos <[EMAIL PROTECTED]> wrote:

Alec Thomas wrote:

+1

it's good it's just in the Wiki module, to see how it goes.

Though my preference would be without the transaction code, I think

Thanks!

changesets:
 -http://trac.edgewall.org/changeset/7340-simplify transactions to
use local functions instead of other methods
 -http://trac.edgewall.org/changeset/7341-show how the above lends
itself to the later use of `with` (transaction as a context manager)

But concerning the transaction stuff, have a look at the follow-up -- Christian

Wanted to try it out, but that 'with transaction....' stuff makes my
Trac crash and burn.

I'm running 2.4.5 from MacPorts and there is no with statement in my
future, so to speak:

In [1]: from __future__ import with_statement
------------------------------------------------------------
SyntaxError: future feature with_statement is not defined (<ipython
console>, line 1)

Oh. I see. I just presumed with was part of 2.5, and in __future__ for
2.4. Now I see it is in __future__ for 2.5, and probably part of 2.6.
Right?

Nice experiment and nice-looking code, but with talk of dropping 2.3.x
for trunk soon I suppose it will be a long time before 2.4.x can be
ditched...

/me heads off to downgrade the branch to previous version to give it a
spin.

You missed the changeset message for r7341 :-)

> WikiRename <http://trac.edgewall.org/wiki/WikiRename>: illustrate the transition towards use of context manager and with statement, for transaction (requires Python 2.5 - not meant for trunk).

So indeed, this was just meant to be illustrative, I'm not sure we can directly bump the requirement to Python 2.5 for Trac 0.12dev, though it was previously mentioned that 2.3 support will be dropped, considering that Genshi 0.6 does so and that this version of Genshi will probably be required at the time of the 0.12 release.

--Noah

Right, I was assuming we will be supporting both 2.4 and 2.5 for the foreseeable future. Given this, the context manager stuff isn't actually helpful. Does anyone know of a good summary anywhere of what OSes use what version of Python?

signature.asc
Description: OpenPGP digital signature