On Sat, Nov 29, 2008 at 4:18 AM, Remy Blank <[EMAIL PROTECTED]> wrote: > Erik Bray wrote: >> +1 here. I've already removed it in my own Trac instances for the >> reasons you've described. At one point I spent some time trying to >> make this a little more dynamic so that columns would be re-added if >> the grouping column was changed, but then you had to keep track of >> whether or not that column was enabled or disabled to begin with, and >> it just becomes too cumbersome. > > I came to the same conclusion. > > It's not the first time that you mention having removed or changed > something in your installations and that has been requested later > independently. Any other good ideas that I could implement? I'm good at > cleaning up :-)
Not really at the moment, though there is a patch I'm about to go work on concerning default values for enum fields. But I'll attach that to a ticket when it's done. >> Easier to just remove the restriction and allow users to add a column >> even if the results are already grouped by that column. Some of my >> users actually wanted to be able to do that so that they could include >> a column when doing a CSV export, but still view the results grouped >> by that column. > > I have implemented something slightly different: I have removed the > algorithm from get_all_columns(), which is used to create the list of > check boxes, so all checkboxes are always present. And I have moved it > into get_default_columns(), which is used when no columns are specified > in the query or URL (i.e. when coming to the query page from a > [query:...] link that has no column specification). That way, existing > queries should not change too much. Sounds like a good compromise. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
