Hi, This is somewhat in reply to http://groups.google.com/group/trac-dev/browse_thread/thread/ded9c142e6fb54c1/072484b41c5f6f60 .
There has been some talk on the trac channel about removing the exist trac-post-commit-hook and replacing it with one of my pluggable solutions: * http://trac-hacks.org/wiki/SvnChangeListenerPlugin : works only with SVN's post commit hook * http://trac-hacks.org/wiki/RepositoryHookSystemPlugin : architected for arbitrary repositories, though currently only implemented for SVN The idea is the contributed script is not pluggable and actually does two unrelated things: 1. gets a changeset from a commit 2. uses the changeset message to close tickets The above plugins separate this functionality and makes it pluggable. Is there any thought about pro vs. con and how to do this (assuming pro)? I recommend the RepositoryHookSystem, even though it is less tested, as (IMHO) it should cover all use-cases while of course SvnChangeListener only works for SVN. I'd be glad to work on a branch and port to trunk but, since its a plugin, I'm not sure what should actually go in the branch. I could add the whole plugin. That would be the simplest. But I'm not sure if this meets with trac's philosophy. Thoughts? your (usually) humble servant, Jeff Hammel Software Engineer - The Open Planning Project http://topp.openplans.org IRC: k0s, jhammel --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
