On Sun, Jan 18, 2009 at 10:41:10PM -0800, Noah Kantrowitz wrote:
> 
> On Jan 18, 2009, at 10:11 PM, Jani Tiainen wrote:
> 
> >
> > Jeff Hammel kirjoitti:
> >> On Sat, Jan 17, 2009 at 01:20:45AM +0200, anatoly techtonik wrote:
> >>> On Wed, Jan 14, 2009 at 5:24 PM, Remy Blank <[email protected]>  
> >>> wrote:
> >>>> Another minor improvement could be to align the diffstats instead  
> >>>> of
> >>>> joining them with the file name. IMO this would look more orderly  
> >>>> (and
> >>>> actually has nothing to do with your proposal :-).
> >>> Speaking about irrelevant proposals I woudn't mind if file viewer
> >>> contained a get "SVN Link" alongside with "Plain text" and "Original
> >>> format" in "Download in other formats" option at the bottom.
> >>> -- 
> >>> --anatoly t.
> >>
> >> There are three components that do similar to this, the  
> >> SvnUrlsPlugin, the SubversionLocationPlugin, and the  
> >> SourceControlURLs component of ClueMapper.  If there was interest  
> >> and agreement on what people needed, I would love to unify these  
> >> components, then possibly ticket this as a core enhancement.
> >
> > If you go this way, don't forget that if it's targetted for core,  
> > there
> > exists many other repository backends than just SVN...
> 
> If anything is done, it would need to be entirely generic anyway. Just  
> give a URI template and it does href=template%node.path or whatnot.

Will do.  First, the different implementations should be compared with mind 
towards unificiation:

 * ClueMapper puts in a link towards the top of 'browser.html' of the form e.g. 
[vc: 
https://dev.serverzen.com/svn/cluemapper/ClueMapper/trunk/src/clue/app/tracplugins/sourcecontrol.py]
 ; this is done using SourceControl().vc_url option from linked-to file

 * SubversionLocationPlugin puts a link next to 'Last Change' in the sub-nav 
menu of the page which is labeled 'Subversion location' and gives the canonical 
URL of the repository.  Notably, this was forked from SvnUrlsPlugin to have 
this more minimalist behavior.  This also only does '/browser' URLs.

 * SvnUrlsPlugin puts the location in 'browser.html' with text '[svn]' and a 
link to the URL location in the same place ClueMapper does. If the location is 
a directory, it also puts such a link in a new column. It also includes links 
in 'revisionlog.html' and 'changeset.html'.  The directory entries can be time 
consuming for large repositories (although were it in trunk, this would be less 
true, I think, since there wouldn't be extra processing for the streamfilter), 
so maybe an option would be needed to turn these off.  An option 
'[svn]\nrepository_url' is used to control this location.

Does anyone have any thought on what would be sought after in a unified plugin? 
 I don't really have strong feelings, as long as those URLs are there when I 
need them.

Although I'm not familiar with the several trac repository types (save SVN), I 
don't imagine making it generic would be a problem.

Jeff Hammel
IRC: jhammel, k0s

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac 
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to