Jonas Borgström wrote: > On 3/25/09 12:40 AM, Remy Blank wrote: > >> The following defect has just been reported: >> >> http://trac.edgewall.org/ticket/8153 >> >> The symptoms are: >> >> - Mainnav entries redirected through [mainnav] with a relative .href >> don't work (most ironical example: the "New ticket" link on t.e.o). >> >> - Redirects for URLs with trailing slashes don't work anymore (e.g. >> /newticket/ redirects to //newticket instead of /newticket, which leads >> to a "page not found" error with tracd). >> >> The regression was introduced in [7930] (yeah, I know, me again). I have >> attached a patch to the ticket that fixes both issues. >> >> IMO this is serious enough to warrant a second release candidate, so I >> suggest we apply the patch and go for another round of testing. >> >> Opinions? >> > > Yes I think so. Or at least delay the release a few more days. > > I can't understand how this managed stay undetected on t.e.o for almost > a full week. But since new tickets were somehow created daily I guess we > had no real reason to suspect anything. >
As you said, other tickets were created in the meantime, and no other regression were found. But it's also OK for me if we release 0.11.4rc2 now and delay the actual release to the end of the week. > Anyway, I've remeved the [mainnav] thing from t.e.o so the new ticket > links should be working again. > > Remy, if you're happy with the patch you have so far please go ahead and > commit it. > The href() semantic change could also have other unattended consequence, for example for plugins. So maybe we should considerer reverting r7930 on the branch, keep it on trunk and mention it as an API change for 0.12 (TracDev/ApiChanges/0.12). Then either fix #8059 differently or consider it fixed for 0.12 only. -- Christian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
