Christian Boos wrote:
> Hey, this one looks great!

I have got some minor nitpicks:

 - Use WikiFormatting for docstrings.

 - The "try: except: raise" in the case where db is not None is not
necessary, just call fn(db).

 - Sort imports alphabetically.

 - Use "cursor" for cursors. That's the convention for the rest of Trac.

 - There's still an "if(new_text)" in save().

> Remy, OK for an experimental branch, starting with this change?

A branch sounds a bit overkill for this, I would have opened a ticket
and tracked progress with patches, and integrated the result into trunk.
But I'm ok if you think it is worth the overhead.

-- Remy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to