Christian Boos wrote: > Well, I think we should now simply invalidate this advice and say that > Trac not only takes care of doing a commit after each step, but that in > addition it should also be possible to perform finer grained commits > inside an upgrade_environment method if appropriate. It's certainly > appropriate for the trac.env.EnvironmentSetup.upgrade_environment method > (i.e. the place where we go through the trac/upgrades/db<version>.py steps).
Committing after each upgrade step sounds reasonable, and I see no disadvantage. Committing *during* an upgrade step opens the possibility to leaving the database in an in-between state, that is, neither the previous version nor the next version. This would either require manually rolling back to the base state for the upgrade, or writing upgrade scripts so that they can handle the situation, which shouldn't be too difficult. So, +1. Any idea what happened in #9268? I haven't tried to reproduce the issue yet. -- Remy
signature.asc
Description: OpenPGP digital signature
