I have been working on integrating the BatchModifyPlugin [1] into the Trac core, hopefully for inclusion in 0.13. This would complete ticket #525. With some guidance from Christian I have created a proposal page [2] and my own fork on GitHub [3]. Things seem to be coming along nicely so I figured I should start getting some feedback. I have read through a good chunk of the TracDev information, but not all of it. If I ask something that is already answered there just let me know.
<disclaimer>I am a fairly novice Python programmer. Professionally I work mostly in C# and JavaScript. If you see naive mistakes in my code feel free to point them out to me. I hope that working on this will help to improve my Python abilities. Until a couple of months ago I had also never used jQuery in a meaningful way either.</disclaimer> First, as Christian noted on the proposal page, I am only working on integrating the plugin as-is. This means ticket changes are not integrated with the timeline and and notifications. However, following the integration of the plugin as-is I am certainly willing to continue to work on that as well. I don't want to bite off more than I can chew up front. The only feature I removed was the ability to not modify the changetime of each ticket that is modified. Some users use the plugin in such a way that modifying changetimes messed up there internal auditing. I don't think this is the sort of feature that belongs in the Trac core though. Second, some I have some style questions. * Currently I have separate files for batch JavaScript and CSS. These are only included on the query page if the batch module is enabled and the user has the TRAC_BATCH_MODIFY permission. Should these be integrated into query.js and report.css? This would eliminate some duplication, but with the side effect that unneeded styles and scripts could be included on the page. Another option would be to refactor query.js so the common functions are not in the ready event. * Are there any guidelines for adding new config options? Currently the plugin has three config options related to the handling of text fields. There a couple of new fields I have considered adding as well, one for excluding certain fields from batch modification and one for adding certain fields by default. The following still needs addressed as well. * Tests - The plugin has a few, but they are not up to snuff. I am quite comfortable with unit testing C# code with NUnit, so I just need to get familiar with the Python tools. * Documentation - I am sure that I will need to add documentation to the wiki. Finally, thanks for all of your hard work on Trac. It makes our dev team's life much easier and gives me some awesome code to play with. Any feedback would be appreciated. -Brian [1] http://trac-hacks.org/wiki/BatchModifyPlugin [2] http://trac.edgewall.org/wiki/TracDev/Proposals/BatchModification [3] http://github.com/CuriousCurmudgeon/trac-batch-modify -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to trac-...@googlegroups.com. To unsubscribe from this group, send email to trac-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
