Mikael Relbe wrote: > I guess I have to try to re-write all of the event-rendering code > then.
I'm not sure about a "re-write". Basically, it's moving the rendering code back into the individual components, which should be pretty mechanical (some self <-> event renames) then remove the TimelineEvent subclasses that don't add anything. Personally, I would do one more iteration over your current patches, but your proposal is fine, too. >> New 'flags' being added to TimelineModule >> that do things such as "Highlight my tickets", has no place in >> Timeline code. I agree with that. I didn't mention it, because I saw those few options more as being "experimental", in the sense that it's one step in a direction, that would allow testing the usability of the functionality, before finally generalizing it in the form of a new interface or an extension to an existing interface. Generalizing too early can sometimes be counter-productive, and experience gathered by a "incomplete" feature often helps shaping the final, general solution. Such experimental code is fine for me on trunk, as long as it doesn't stay in this form until the next release. It should either be refactored and cleaned up, or removed if the experiment fails. That's a personal opinion, though, and other may disagree. -- Remy
signature.asc
Description: OpenPGP digital signature
