(CC: to trac-dev, we want to have such discussions in public.) Peter Suter wrote: > I think it would be great if we could include this plugin in Trac. > (Would be a nice "bonus" for Trac 1.0 :)
Yes, that would be awesome. > While I'm not much of a git user, I'd like to know if there's anything I > could do to help. I'd (naively) expect the next steps are something like: > > * Commit that snapshot to SVN to > https://svn.edgewall.org/repos/trac/plugins/0.13/git-plugin/ or > https://svn.edgewall.org/repos/trac/trunk/tracopt/versioncontrol/git/ I'm not sure either what the best location would be. The Mercurial plugin has to be separate from Trac itself due to the license, but this wouldn't need to be the case for the Git plugin. So "tracopt" would be the simplest for our users, and they would have it installed already and would only need to enable it. If we do that, we could also move `svn_fs.py` out of `trac.versioncontrol` and into `tracopt.versioncontrol`, for consistency. Just make sure you do each step in a separate changeset, so that we can easily roll back one or the other if necessary. In particular, the initial import should add the files from the git repository unchanged, so that all diffs against the original are explicitly visible. > * Adjust the license file headers somehow? (future27.py has a strange one) > * Review and cleanup according to [[TracDev/CodingStyle]] This should probably include moving the few existing unit tests in `future27.py` out of the `__main__` section of that file into `tests/future27.py` and having it called as part of the normal unit tests. > * Setup a git mirror If we move it to `tracopt`, this wouldn't be necessary. > == Wiki > * Create a page at http://trac.edgewall.org/wiki/TracGit or GitPlugin to > document this. > > == Tickets > * Create a ticket component 'plugin/git' on t.e.o. > * Migrate existing trac-hacks tickets to t.e.o. somehow? If there are many tickets, we could find a way to import them automatically. Otherwise, just copy / paste the relevant ones, and close the rest. > Maybe we should open a ticket for this migration itself? Yes, please do. Thanks for tackling this! -- Remy
signature.asc
Description: OpenPGP digital signature