On 05.08.2013, at 05:26, Jun Omae <[email protected]> wrote: > Hi, Clemens > > On Mon, Aug 5, 2013 at 1:58 AM, Clemens Gruber <[email protected]> wrote: >> Solution: >> Implement a warning function which logs the error, and set this function via >> svn.fs.svn_fs_set_warning_func >> >> What do you think? > > Sounds good. The default function for fs->warning calls `abort()`. > > I created the patch. After the patch, when a warning on svn.fs happens, Trac > writes the warning using TracLogging. However, I cannot currently reproduce > the issue. Could you please try the patch? > > -- > Jun Omae <[email protected]> (大前 潤) > > -- > You received this message because you are subscribed to the Google Groups > "Trac Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/trac-dev. > For more options, visit https://groups.google.com/groups/opt_out. > > > <using-svn_fs_set_warning_func.diff>
Hi Jun, Thank you very much for your patch! I tried to reproduce it on my desktop machine, but I wasn't able to do so. The error occurred on a production machine. If it is absolutely necessary, I could try to get some downtime and experiment there, to give you a test-case. But this patch is not very complicated, the logging function looks ok and as long as the warning function is set, it does not abort anymore. That's the most important feature of this patch ;-) Could you please apply it to the current trunk? It shouldn't do any harm, should it? Thanks again for your help! Clemens -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
