On Mon, Nov 25, 2013 at 11:47 AM, Jun Omae <jun6...@gmail.com> wrote: [...]
> > >> 1. Do not allow uploading such attachments at all > >> 2. Allow uploads and support new line chars in attachments web UI > >> 3. Keep things as they are now i.e. allow uploads and still fail to > >> match attachment web UI requests > >> > >> It seems to me that (1) is the best approach . > > 4. Replace unicode control codes with spaces. > I'm not very fond of this approach but (like I just said) it seems others are taking the lead on doing so ... ;) > > See attachment-ctrl-codes.diff. > You'll need something similar in attachments admin component, and everywhere an attachment might be created so I guess it's better to add this check in Attachement (model) class itself ? -- Regards, Olemis - @olemislc Apache™ Bloodhound contributor http://issues.apache.org/bloodhound http://blood-hound.net Blog ES: http://simelo-es.blogspot.com/ Blog EN: http://simelo-en.blogspot.com/ Featured article: -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-dev+unsubscr...@googlegroups.com. To post to this group, send email to trac-dev@googlegroups.com. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
