On Sun, May 10, 2015 at 7:50 PM, Walty Yeung <wal...@gmail.com> wrote: > > hi ryan, > > thanks for your detailed instructions. two quick questions, just to make > sure I did fully understand the suggestions: > > 1. Where could I get the changes of review? should I read the timeline > page (http://trac.edgewall.org/timeline)? Or is there some other places I > could read the reviews? >
Yeah, following the timeline (you can subscribe in an RSS feed reader) is the way to keep track of progress on the project, as well as subscribing to trac-users and trac-dev mailing lists. > 2. I currently checked out the trunk version of trac, and set up a > development environment in my mac. So, would u suggest to set up virtualbox > of ubuntu and windows to do a through testing before submitting the > patches? Or I could do that a little bit later? > To start with I think it's perfectly fine to develop on just the Mac. We'll review your patches for platform-related issues and run the tests before committing. At least, I always intend to do that, but even when I introduce issues on other platforms or even forget to run the tests, the issues are usually caught by the other devs very quickly. We have automated testing running on Linux via Travis CI, and eventually I hope we can setup to test for Windows on AppVeyor (1). I think I recall seeing the other day a similar service for OSX, but I'd have to dig in my notes to be sure. As a first step, I suggest just trying to run the tests (2, 3) on your OSX machine. Read the output and you'll probably find some tests being skipped, suggesting that you need to install more dependencies. I imagine you'll run into an unresolved issue I encountered when starting to develop on the Mac a few weeks back (3), or perhaps you'll find an entirely new issue! Either way, it's good to establish that baseline and know what to expect from the tests on your platform before you start editing code. Starting out with Trac development is also a great opportunity to show us where we can improve the documentation for new developers. There are many things we'll have overlooked after working on the project for some time. Any suggestions are welcomed! (1) http://www.appveyor.com/ (2) http://trac.edgewall.org/wiki/TracDev/UnitTests (3) http://trac.edgewall.org/wiki/TracDev/FunctionalTests (4) http://trac.edgewall.org/ticket/12022 -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-dev+unsubscr...@googlegroups.com. To post to this group, send email to trac-dev@googlegroups.com. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/d/optout.
