Hello Ryan, On 1/13/2017 12:32 AM, RjOllos wrote: > > Some JavaScript issues noted so far: > > * Missing group toggle checkbox on these tables: > /admin/ticket/components, /admin/ticket/milestones, > /admin/ticket/versions, /admin/versioncontrol/repository > * Missing group toggle feature on permissions table (#11417) > * Divs for plugins are not foldable on /admin/general/plugin
All due to missing "block head" in these templates, around the <script> tags. > Also: > * On /roadmap, "Hide milestone with no due date" doesn't seem to stick, > though the submitted value appears to be effective in filtering the > milestones One "|htmlattr" filter missing. > * Some margin above "Repository Index" h1 on /browser page might be good Right, I removed the <br> but forgot to adjust this. > * "Visit", "View revisions", "View diff against" options on /browser > page might look better with bigger or different font Oops, they still had a "10px", I need to check again for fixed sized fonts, as obviously I missed some. Actually I missed a lot ;-) > * Name input on /admin page could be made same width as URL input > (General: Basic Settings) OK. > * Very minor preference: I like having just the box-shadow around the > label for the folding links (e.g. Attachments on ticket page), rather > than a border + box-shadow. Similarly for the folding links on the > plugin admin page where the corners of the box at least look too square, > might be better with a box-shadow and/or rounded. I made it a bit lighter, but no border at all counters the more "crisp" aspect I want to get overall. I obviously like box shadows as I put them everywhere, but after a while I felt that I've added too much "fuzziness". > Unrelated, it was a long time before I noticed the "View changes..." > button on the bottom of the /browser page. I think this has been > discussed in a ticket, but maybe that button should be made a link in > the context nav? I'll first see how well my idea of page "actions" would work. I'm thinking of a kind of "menu" for links/buttons that apply on the resource itself. For wiki pages, that would be Edit / Attach / Rename / History / Delete version / Delete page. For tickets, that would be Modify / Attach / Comment / Delete. "Report spam" would also go there rather than into the context navigation. Context navigation will instead refocus on links to other resources (the start, parent, and index for the wiki; the query, prev, and next for tickets). If that works well for the wiki page, ticket and milestone, I can do that for the browser page as well, and then the "View changes..." will be one of the actions. > I'll do more testing later today, or in coming days. That would be great! Thanks for the feedback so far. Here are the corresponding fixes: (jinja2-trunk-r15341 branch) - [a47b48a3/cboos.git] (#12639): fixing bugs spotted by Ryan. (wiki-restyling branch) - [6ff2ec27/cboos.git] (#633) second round... - [1fbf96ce/cboos.git] (#12640) minor tweaks of foldable border, ... Also, what would be great is if you (or anyone else for that matter) could try to convert some plugins templates to Jinja2. That way, you could tell me what is not clear in the migration guide, or simply still missing from it. -- Christian -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to trac-dev+unsubscr...@googlegroups.com. To post to this group, send email to trac-dev@googlegroups.com. Visit this group at https://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/d/optout.
