Christopher Lenz wrote:
Am 31.01.2006 um 15:26 schrieb Alec Thomas:
On Tue, Jan 31, 2006 at 12:36:08PM +0100, Christian Boos wrote:
...
I'm quite interested from feedback from alec, since he uses a similar
modification on Trac hacks.
I like the more verbose change log, obviously ;)
Not sure about the ticket summary though. I have ticket_show_details
enabled and the timeline looks quite cluttered with the summary
displayed for each ticket event.
I've never really had a problem with not having the summary in the
ticket events anyway, I find it trivial just to hover over the ticket
link.
Same here, I agree about the added clutter.
Thanks for the feedback, I'll give this some more thought.
The get_event_data() refactoring doesn't sound that good to me,
either. This is an API that is explicitly intended to be used by
extenders, and for that it feels a bit too cheesy. I'd rather have us
create a TimelineEvent class for returning events from providers or
something to that effect.
That was a way to avoid repeating errors (got another wiki_to_html
missing its `req` argument along the way :) )
I'll look how a class would do there.
About href/abs_href: this is something that has annoyed be for a long
time. Sometimes I tend to leave obvious smells in the code as a
reminder that a better solution is needed. Somehow we need to find a
better way to solve this problem, not patching layers over it.
So what about my suggestion written somewhere else, that we should use
req.abs_ref/href
and env.href (set from the base_url) only when there's no req available?
-- Christian
_______________________________________________
Trac-dev mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-dev
