John Hampton wrote:
Jonas Borgström wrote:
Thanks, applied in r2981.
Cool. I took a look at the diff, and it still looks slightly broken. I
haven't tested it out yet, but it actually looks a little more broken
than before.
in trac/web/standalone.py line 259, there is a call to usage() that
wasn't there before. I don't believe that that was part of my patch.
Anyway, the call to usage() is not needed. One, it's not actually
defined, so it borks. Two, optparse takes care of catching the
OptionValueError and then printing the string passed with the exception
and the usage. So line 259 should be taken out.
If I'm wrong, please let me know, as I haven't tested it, but the way it
stands in 2981, I don't believe tracd will work at all if you pass it
the -a flag (or --basic-auth).
Yeah, you're right, I didn't actually apply the patch but fixed it
directly but unfortunately only verified that the error message was
printed and not that it worked when used correctly.
It should be fixed now anyway.
Cheers,
Jonas
_______________________________________________
Trac-dev mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-dev
