#2346: Timeline should handle being unable to contact subversion better
------------------------------+---------------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.9.3
Component: timeline | Version: 0.9
Severity: minor | Resolution:
Keywords: |
------------------------------+---------------------------------------------
Comment (by cboos):
Answering to cmlenz:
1. If the user checks the filter and update, nothing happens
(see comment 01/02/06 07:18:00).
OTOH, I agree that putting the error message there is clumsy.
That's was one of the only idea I came with for giving a feedback
to the user, though (the other idea was to create a ''faked'' error
changeset... I think that'd be even worse :) ).
Besides modifying the API in order to be able to report errors,
of course.
2. OK
3. A !TracError occurring when simply doing a `self.env.get_repository()`
obviously means that we can't get the repository... As to know if this
is only temporary, well, that's just based on the assumption the admin
will be able to notice the issue, and recover access.
Simply logging the error and keeping the filter might make the detection
of a problem a little harder/slower: you'd have to know that there
''ought''
to be changesets but they are not there, before thinking about checking
the log... An explicit error feedback would be better, see 1.
Disabling the filter checkbox would be a good solution.
Maybe the error could be shown as a tooltip for the disabled filter
(like ''Filter disabled: ...'').
We could use a fourth optional return value for `get_timeline_filters`.
If it's a `string`, it's taken to be an error message and we disable the
filter?
--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2346>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets