#2764: [PATCH] Arbitrary line highlight in html preview
-------------------------------------------+--------------------------------
 Reporter:  Tim Hatch <[EMAIL PROTECTED]>  |        Owner:  cboos   
     Type:  enhancement                    |       Status:  assigned
 Priority:  normal                         |    Milestone:  0.10    
Component:  browser                        |      Version:  devel   
 Severity:  minor                          |   Resolution:          
 Keywords:                                 |  
-------------------------------------------+--------------------------------
Comment (by Tim Hatch <[EMAIL PROTECTED]>):

 That sounds good.  Take
 [http://trac.timhatch.com/demo1/browser/INSTALL?rev=2&mark=20-22,38,46-
 50#L19 this url] - how should it be specified using the wiki syntax, where
 the line and first mark are different?

 Although I dislike the added complication, but I would favor splitting up
 the hashref itself and the lines to mark, like {{{source:/path/to/[EMAIL 
PROTECTED]
 (20-22,38,46-50)19}}}.  This does not change the existing {{{#L19}}}
 syntax, where your patch does (instead of just going to the line, it also
 marks it).

 The [attachment:ticket:2764:mimeview-annotate-marks4.diff marks4 patch]
 uses this alternate syntax.

 If the line and marks are jumbled together, I suggest making the {{{line =
 max(0, Ranges(marks).pairs[0][0]-1)}}}, since that is sorted, and it's
 easier to read the preview with one line of context above the start of
 marks.

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2764>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets

Reply via email to