#2891: Timeline performance broken in [2990]
----------------------------------+-----------------------------------------
 Reporter:  [EMAIL PROTECTED]     |        Owner:  cboos   
     Type:  defect                |       Status:  assigned
 Priority:  highest               |    Milestone:  0.10    
Component:  timeline              |      Version:  0.9.4   
 Severity:  normal                |   Resolution:          
 Keywords:  timeline performance  |  
----------------------------------+-----------------------------------------
Changes (by cboos):

  * priority:  normal => highest

Comment:

 Please try out the following patch:
 {{{
 Index: trac/versioncontrol/web_ui/changeset.py
 ===================================================================
 --- trac/versioncontrol/web_ui/changeset.py     (revision 3015)
 +++ trac/versioncontrol/web_ui/changeset.py     (working copy)
 @@ -651,16 +651,17 @@
              rev, path = chgset[:sep], chgset[sep:]
          else:
              rev, path = chgset, None
 -        repos = self.env.get_repository()
 -        try:
 -            chgset = repos.get_changeset(rev)
 +        cursor = formatter.db.cursor()
 +        cursor.execute('SELECT message FROM revision WHERE rev=%s',
 (rev,))
 +        row = cursor.fetchone()
 +        if row:
              return '<a class="changeset" title="%s" href="%s">%s</a>' \
 -                   % (util.escape(util.shorten_line(chgset.message)),
 +                   % (util.escape(util.shorten_line(row[0])),
                        formatter.href.changeset(rev, path), label)
 -        except TracError, e:
 -            return '<a class="missing changeset" title="%s" href="%s"' \
 +        else:
 +            return '<a class="missing changeset" href="%s"' \
                     ' rel="nofollow">%s</a>' \
 -                   % (str(e), formatter.href.changeset(rev, path), label)
 +                   % (formatter.href.changeset(rev, path), label)

      def _format_diff_link(self, formatter, ns, params, label):
          def pathrev(path):
 }}}

-- 
Ticket URL: <http://projects.edgewall.com/trac/ticket/2891>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets

Reply via email to