#3015: Please display properties in the browser view with the newlines still
intact
------------------------------------------+---------------------------------
Reporter: Russell Hind <[EMAIL PROTECTED]> | Owner: cboos
Type: enhancement | Status: assigned
Priority: normal | Milestone: 0.10
Component: browser | Version: 0.9.4
Severity: minor | Resolution:
Keywords: svn properties |
------------------------------------------+---------------------------------
Changes (by cboos):
* status: new => assigned
* severity: normal => minor
* owner: jonas => cboos
* milestone: => 0.10
* keywords: => svn properties
Comment:
Sure.
{{{
Index: browser.py
===================================================================
--- browser.py (revision 3124)
+++ browser.py (working copy)
@@ -26,7 +26,7 @@
from trac.mimeview import Mimeview, is_binary, get_mimetype
from trac.perm import IPermissionRequestor
from trac.util import sorted
-from trac.util.markup import escape, html
+from trac.util.markup import escape, html, Markup
from trac.web import IRequestHandler, RequestDone
from trac.web.chrome import add_link, add_stylesheet,
INavigationContributor
from trac.wiki import wiki_to_html, wiki_to_oneliner, IWikiSyntaxProvider
@@ -103,14 +103,19 @@
node = get_existing_node(self.env, repos, path, rev_or_latest)
hidden_properties = self.config.getlist('browser',
'hide_properties')
+ properties = []
+ for name, value in node.get_properties().items():
+ if not name in hidden_properties:
+ if value and '\n' in value:
+ value = Markup('<br />'.join([escape(v) for v in
+ value.split('\n')]))
+ properties.append({'name': name, 'value': value})
req.hdf['title'] = path
req.hdf['browser'] = {
'path': path,
'revision': rev,
- 'props': [{'name': name, 'value': value}
- for name, value in node.get_properties().items()
- if not name in hidden_properties],
+ 'props': properties,
'href': req.href.browser(path, rev=rev),
'log_href': req.href.log(path, rev=rev),
'restr_changeset_href': req.href.changeset(node.rev,
}}}
--
Ticket URL: <http://projects.edgewall.com/trac/ticket/3015>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets
