#2974: Attachments Fooling Browsers
-------------------------------------+--------------------------------------
Reporter: anonymous | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.10
Component: general | Version: 0.9.4
Severity: normal | Resolution:
Keywords: attachment file preview |
-------------------------------------+--------------------------------------
Comment (by cboos):
In attachement:browser_html_txt.patch, I think I also solved the issue
for the TracBrowser.
The principle is similar:
* adding the `.html` suffix when rendering a preview for a file in the
repository
* adding the `.txt` suffix when sending it plaintext; note that this
should also be done for attachments, in the first patch.
* adding nothing when viewing the raw file.
Also note that I didn't do the required change besides from the browser.py
file,
so it's certainly the case that there are other browser links that will
need to
be modified.
Now, in order to generalize the addition of a suffix in everycase
but the `raw` format, I think we need to consider that when we
generalize #2296 to attachments and to the source browser, perhaps
by using the `key` argument as the suffix (and rename `key` to
`format` or `extension`?).
--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2974>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets
