#3326: Improvements to PHP highlighter
-------------------------------------------+--------------------------------
Reporter: Tim Hatch <[EMAIL PROTECTED]> | Owner: jonas
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: general | Version: devel
Severity: minor | Keywords:
-------------------------------------------+--------------------------------
Two minor issues with the PHP highlighter
(source:trunk/trac/mimeview/php.py):
1. The output of {{{php -sn}}} includes _two_ junk lines at the bottom,
although the second one doesn't include the trailing {{{\n}}}. The last
line is a {{{</code>}}} that definitely should be stripped. That second-
to-last line is a {{{</span>}}} which was messing up validation but
apparently not caught because it didn't cause any weirdness.
2. {{{php -sn}}} has this nasty tendency to close tags on the line past
where it'd seem logical to close them. This causes a lot of unnecessary
html code, and in the interest of sending less data over the wire, this
can easily be worked around. I've modified the PHPDeuglifier to scooch
the close tags up to where they belong. I'm sad to see this gotcha leave,
as it's what let me find #3262.
I've tested both of these points for consistency against PHP 4.3.10-16 on
Debian, 4.4.1 on Windows, and 5.1.4-p10 on Gentoo.
Attaching a patch in a sec.
--
Ticket URL: <http://projects.edgewall.com/trac/ticket/3326>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets
