#3392: Email notification uses username instead email setting
-----------------------------------+----------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: jonas
Type: defect | Status: new
Priority: low | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Keywords:
-----------------------------------+----------------------------------------
We're currently using apache with mod_auth_kerb -
http://modauthkerb.sourceforge.net/. Unlike mod_auth_sspi, you can not
disable including the domain name in the REMOTE_USER variable. So we
authenticate against subversion and trac as [EMAIL PROTECTED]
A small quirk occurs when enabling email notification. Although, users
configure their email address in Settings, their username still takes
priority. Our internal domain name does match our domain used for our
email, so nothing is sent out.
I found the small change in Notify.py that does what seems intuitive;
setting email overrides the username as an email address. Here's the diff
(just swapping the conditions):
{{{
--- Notify_1.py Wed Jul 12 21:03:17 2006
+++ Notify_2.py Wed Jul 12 12:26:59 2006
@@ -300,10 +300,10 @@
# now convert recipients into email addresses where necessary
emails = []
for recipient in recipients:
- if recipient.find('@') >= 0:
- emails.append(recipient)
- elif self.email_map.has_key(recipient):
+ if self.email_map.has_key(recipient):
emails.append(self.email_map[recipient])
+ elif recipient.find('@') >= 0:
+ emails.append(recipient)
# Remove duplicates
result = []
}}}
Regards,
Craig Barber
--
Ticket URL: <http://trac.edgewall.org/ticket/3392>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac-tickets
